Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updates the broken links in ingress-controller and kubernetes-apps un… #10239

Merged
merged 1 commit into from
Jun 22, 2023
Merged

Updates the broken links in ingress-controller and kubernetes-apps un… #10239

merged 1 commit into from
Jun 22, 2023

Conversation

vaibhav2107
Copy link
Contributor

@vaibhav2107 vaibhav2107 commented Jun 20, 2023 •
edited by floryut
Loading

What type of PR is this?
/kind documentation

What this PR does / why we need it:
Broken links in ingress-controller and kubernetes-apps under kubespray docs

Which issue(s) this PR fixes:

Fixes #10238

Special notes for your reviewer:
n/a

Does this PR introduce a user-facing change?:

Updates links in ingress-controller and kuberentes-apps

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jun 20, 2023
@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jun 20, 2023
@k8s-ci-robot
Copy link
Contributor

Hi @vaibhav2107. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@vaibhav2107
Copy link
Contributor Author

/kind documentation

@k8s-ci-robot k8s-ci-robot added kind/documentation Categorizes issue or PR as related to documentation. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 20, 2023
@vaibhav2107
Copy link
Contributor Author

Hi @cristicalin @jayonlau
Could you please have a look

@MrFreezeex
Copy link
Member

Hi, could you rebase the PR to fix the CI? Thanks 🙏
/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 21, 2023
MrFreezeex
MrFreezeex approved these changes Jun 22, 2023
View reviewed changes
Copy link
Member

@MrFreezeex MrFreezeex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for these nice doc cleanup and for the rebase 🙏 :D!
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 22, 2023
@vaibhav2107
Copy link
Contributor Author

Thanks @MrFreezeex

floryut
floryut approved these changes Jun 22, 2023
View reviewed changes
Copy link
Member

@floryut floryut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vaibhav2107 Thank you
But please next time, keep the PR template and fill in your info.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: floryut, MrFreezeex, vaibhav2107

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 22, 2023
@vaibhav2107
Copy link
Contributor Author

@floryut Yes sure, Thanks

@k8s-ci-robot k8s-ci-robot merged commit a1521dc into kubernetes-sigs:master Jun 22, 2023
maciej-markowski pushed a commit to maciej-markowski/kubespray that referenced this pull request Jun 23, 2023
@vaibhav2107 @maciej-markowski
Updates the broken links in ingress-controller and kubernetes-apps un…
ea3f051 
…der kubespray docs (kubernetes-sigs#10239)
@yankay yankay mentioned this pull request Aug 24, 2023
Closed
pedro-peter pushed a commit to pedro-peter/kubespray that referenced this pull request May 8, 2024
@vaibhav2107 @pedromcpedro
Updates the broken links in ingress-controller and kubernetes-apps un…
201a1db 
…der kubespray docs (kubernetes-sigs#10239)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@floryut floryut floryut approved these changes

@MrFreezeex MrFreezeex MrFreezeex approved these changes

@cristicalin cristicalin Awaiting requested review from cristicalin

@jayonlau jayonlau Awaiting requested review from jayonlau

Assignees

@MrFreezeex MrFreezeex

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/documentation Categorizes issue or PR as related to documentation. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Broken links in ingress-controller and kubernetes-apps under kubespray docs
4 participants
@vaibhav2107 @k8s-ci-robot @MrFreezeex @floryut